security: replace python-jose with PyJWT for JWT handling#250
Closed
PeakPy wants to merge 1 commit intobenavlabs:mainfrom
Closed
security: replace python-jose with PyJWT for JWT handling#250PeakPy wants to merge 1 commit intobenavlabs:mainfrom
PeakPy wants to merge 1 commit intobenavlabs:mainfrom
Conversation
Collaborator
|
Thanks for the PR! However, we tested this and the vulnerability doesn't actually apply to this project. We're on python-jose 3.5.0, which already rejects alg=none tokens when algorithms=["HS256"] is explicitly specified which is what we do on every jwt.decode The CVE was valid for older versions of the library, but 3.5.0 already addresses it. Since there's no actual security issue here and the migration introduces Appreciate you looking into it though! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces
python-josewithPyJWTto address known security vulnerabilities (CVE-related to alg=none bypass and denial-of-service).Partially addresses #248 (JWT security concern)
Changes
python-jose>=3.3.0dependencyPyJWT>=2.8.0dependencysecurity.pyto use PyJWT APIlogout.pyto catchjwt.PyJWTErrorexpclaim to Unix timestamp for PyJWT complianceuv.lockwith new dependency treeTests
All existing tests pass (11/11):
Checklist
Additional Notes