Respect connect timeout in ssl:connect #776
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
savonarola
changed the title
benoitc
added a commit
that referenced
this pull request
Jul 24, 2025
Measure elapsed time during TCP connection and pass remaining timeout to SSL handshake. Handle infinity timeout case and close socket on timeout. Closes #776
Owner
|
Thank you. I've updated your PR to take care of the infinity case in #781 . However i'm wondering if i's acually makes sense to do this since if we have now a socket why would we timeout ? Do you have any specific use case in mind? |
benoitc
added a commit
that referenced
this pull request
Jul 24, 2025
Measure elapsed time during TCP connection and pass remaining timeout to SSL handshake. Handle infinity timeout case and close socket on timeout. Closes #776
Contributor
Author
|
Hello! I hit this case when testing an app under emulation of network data loss. The connection process took unexpectedly long time to fail. Since the handshake involves network operations, this seems to be a possible situation in a real environment. We connect but sometimes lose the subsequent packets, causing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After socket connection called with timeout,
ssl:connect(the handshake) is called without timeout. But the handshake may last long and easily exceed the expected connect timeout. So we usessl:connect/3to limit the handshake time too.