Repository navigation
fix: declare MAX_ARRAY_LENGTH before instance fields (SpotBugs IMC) - #164
Merged
Merged
Conversation
fb-contrib IMC_IMMATURE_CLASS_WRONG_FIELD_ORDER failed the spotbugs-check (verify phase) after #163 placed the static constant between instance fields. Moved it next to the other static field; no behavior change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018mLGtytvtJU7aNshBpnrB5
bernardladenthin
had a problem deploying
to
startgate
September 30, 2026 21:32 — with 
GitHub Actions
Error
GitHub Actions
Error
bernardladenthin
had a problem deploying
to
maven-central
September 30, 2026 21:32 — with
GitHub Actions
Failure
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
September 30, 2026 21:32 — with
GitHub Actions
Failure
GitHub Actions
Failure
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IMC_IMMATURE_CLASS_WRONG_FIELD_ORDERfailedspotbugs-checkin the verify phase, which broke "Build and analyze". The cause was fix: cap byte[] allocations at MAX_ARRAY_LENGTH (Integer.MAX_VALUE - 8) #163 placing the static constantMAX_ARRAY_LENGTHbetween instance fields.Test plan
mvn verify, 296 testsmainwithIMC_IMMATURE_CLASS_WRONG_FIELD_ORDER, passes with this change (BugInstance size is 0)Related issues / PRs
Follow-up to #163
Checklist
CONTRIBUTING.mdandCODE_OF_CONDUCT.mdSECURITY.md)🤖 Generated with Claude Code
https://claude.ai/code/session_018mLGtytvtJU7aNshBpnrB5