Skip to content

Conversation

@tychedelia
Copy link
Member

Fixes #22225

Supersedes #22242 with a little less code

Haven't tested since I don't have access to a software renderer at the moment.

@tychedelia tychedelia added this to the 0.18 milestone Dec 24, 2025
@tychedelia tychedelia added A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash P-Regression Functionality that used to work but no longer does. Add a test for this! labels Dec 24, 2025
@tychedelia tychedelia added the S-Needs-Review Needs reviewer attention (from anyone!) to move forward label Dec 24, 2025
@tychedelia tychedelia added the S-Needs-Testing Testing must be done before this is safe to merge label Dec 24, 2025
@natepiano
Copy link
Contributor

Cool - I will test it to confirm. Maybe not tomorrow (now today) - busy day. But shortly for sure.

@natepiano
Copy link
Contributor

On my windows vm (on my Mac) using software renderer, i tested this PR on a trivial app.run() and it worked. I tested it on my slightly more complex example in my lib project and it worked. Seems to be all good. I will close my PR to clean things up but AFAIK #22254 is good to go.

The resizing example: cargo run --example resizing still fails with the following on my cpu renderer. Addressing resizing example is not part of this fix - but as an FYI, pasting the error here:

2025-12-26T21:48:08.450155Z  INFO bevy_render::renderer: AdapterInfo { name: "Microsoft Basic Render Driver", vendor: 5140, device: 140, device_type: Cpu, driver: "10.0.26100.7309", driver_info: "", backend: Dx12 }
2025-12-26T21:48:08.450423Z  WARN bevy_render::renderer: The selected adapter is using a driver that only supports software rendering. This is likely to be very slow. See https://bevy.org/learn/errors/b0006/
2025-12-26T21:48:09.163924Z  INFO bevy_render::batching::gpu_preprocessing: GPU preprocessing is fully supported on this device.
2025-12-26T21:48:09.176301Z  INFO bevy_winit::system: Creating new window Resizing (0v0)
error: process didn't exit successfully: `target\debug\examples\resizing.exe` (exit code: 0xc0000005, STATUS_ACCESS_VIOLATION)

@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Needs-Review Needs reviewer attention (from anyone!) to move forward S-Needs-Testing Testing must be done before this is safe to merge labels Dec 26, 2025
@tychedelia
Copy link
Member Author

Thanks for testing!

@james7132 james7132 added this pull request to the merge queue Dec 26, 2025
Merged via the queue into bevyengine:main with commit b176e18 Dec 26, 2025
38 checks passed
mockersf pushed a commit that referenced this pull request Dec 30, 2025
Fixes #22225

Supersedes #22242 with a little
less code

Haven't tested since I don't have access to a software renderer at the
moment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-Rendering Drawing game state to the screen P-Crash A sudden unexpected crash P-Regression Functionality that used to work but no longer does. Add a test for this! S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Window resize crashes on DX12 software renderer in 0.18.0-rc.1 (regression from 0.17.3)

5 participants