move settings files to app dir in any case#907
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR relocates GUI-related settings/state/error-log files into a per-user application directory consistently (not only in frozen builds), and adjusts error logging to use the new location.
Changes:
- Remove
ERROR_LOG_FILEfrombirdnet_analyzer.configand define GUI-specificERROR_LOG_FILEinbirdnet_analyzer.gui.settings. - Update GUI settings/state file paths to always live under the user app directory.
- Route runtime error logging through
birdnet_analyzer.gui.settings.write_error_logand update GUI UI references to the new error-log path.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
birdnet_analyzer/utils.py |
Removes legacy error-log helpers and redirects runtime error logging to GUI settings’ writer. |
birdnet_analyzer/gui/utils.py |
Updates error-log UI display/readback to use settings.ERROR_LOG_FILE. |
birdnet_analyzer/gui/settings.py |
Defines app dir, settings/state/error-log paths under it, and implements write_error_log. |
birdnet_analyzer/config.py |
Removes the global ERROR_LOG_FILE constant. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.