feat!(chain): implement CheckPointEntry WIP#2017
Closed
LagginTimes wants to merge 4 commits intobitcoindevkit:masterfrom
Closed
feat!(chain): implement CheckPointEntry WIP#2017LagginTimes wants to merge 4 commits intobitcoindevkit:masterfrom
CheckPointEntry WIP#2017LagginTimes wants to merge 4 commits intobitcoindevkit:masterfrom
Conversation
Member
|
I was talking to @LLFourn about this and he suggested an alternative approach. Instead of introducing a new concept ( This means we can push empty The downside of this is we are introducing an invariant to |
What still needs to be done: * Figure out best practice with handling `CheckPointEntry::Backref`s that connect. * Methods that build on `CheckPoint` need to check that `backref`s connect. * Tests. * Docs. (cherry picked from commit 8f374cc)
bb4ea2d to
495536f
Compare
6 tasks
Contributor
Author
|
Replaced with #2024. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR builds on #1582 and introduces a new
CheckPointEntrytype to represent checkpoints in a more structured way. It captures both the block data and optional backreferences, enabling chains to be merged even without an explicit point of agreement.WIP
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
New Features:
Bugfixes: