Reduce CUDA build matrix, better fallback for lib loading#1980
Merged
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1778
Instead of failing when the exact CUDA/ROCm library version isn't packaged, bitsandbytes now selects the closest available version within the same major and logs a warning. Also fixes ROCm double-digit minor version parsing (e.g. for ROCm 7.13), reduces the CUDA build matrix to the most commonly deployed builds (i.e. those with official PyTorch wheels), and cleans up related diagnostics and error messaging.
This also reduces our wheel size. It is more relevant now after the recent addition of #1949 increased the binary sizes, but in fact brings our wheel much below v0.49.2 release as well.