perf(dev): skip current setup during just dev - #189
Conversation
morgmart
left a comment
morgmart
left a comment
There was a problem hiding this comment.
🤖 Automated code review
REQUEST_CHANGES. The incremental dependency guard can accept a partial or failed SDK build as current, so the automatic repair path is not reliable. The supplied GitHub evidence is structurally valid and all nine check runs for the exact head SHA completed successfully; required checks still govern merge readiness.
Deterministic publication result: 1 blocking and 0 non-blocking inline finding(s) publishable; 0 duplicate(s) suppressed; 0 blocking screenshot-evidence requirement(s) in this review body.
Signed-off-by: John Tennant <jtennant@block.xyz>
morgmart
left a comment
morgmart
left a comment
There was a problem hiding this comment.
🤖 Automated code review
REQUEST_CHANGES. The prior SDK freshness issue is fixed with success-stamp invalidation, complete package-export checks, and discriminating regressions. One analogous dependency-repair path still retains an old success stamp across a failed install, allowing a later launch to skip the needed retry. All 10 supplied GitHub check runs for the exact head SHA completed successfully; the combined commit status is pending with no status contexts, so required checks still independently govern merge readiness.
Deterministic publication result: 1 blocking and 0 non-blocking inline finding(s) publishable; 0 duplicate(s) suppressed; 0 blocking screenshot-evidence requirement(s) in this review body.
Signed-off-by: John Tennant <jtennant@block.xyz>
morgmart
left a comment
morgmart
left a comment
There was a problem hiding this comment.
🤖 Automated code review
APPROVE. The full exact PR comparison now invalidates dependency and SDK success stamps before repair, restores them only after successful completion, verifies all package-exported SDK outputs, and includes discriminating regressions for both interrupted repair paths. Both prior automated findings are fixed, so they are not findings or duplicate suppressions. All 10 supplied GitHub check runs for the exact head SHA completed successfully; the combined commit status is pending with no status contexts, so required checks still independently govern merge readiness.
Deterministic publication result: 0 blocking and 0 non-blocking inline finding(s) publishable; 0 duplicate(s) suppressed; 0 blocking screenshot-evidence requirement(s) in this review body.
Pending checks: 1 check(s) are not complete.
This approval reflects the completed code review only; merge readiness remains governed by the repository's required checks.
2 participants
Summary
just devcurrently reruns dependency installation, SDK compilation, hook setup, and managed Goose setup before every launch. It now verifies pnpm and SDK inputs with worktree-local success stamps, rebuilds only stale outputs, and delegates managed Goose freshness to its existing stamped ensure path. Dependency installs and SDK rebuilds invalidate their prior success stamps before work begins and publish replacements only after success, so interrupted repairs retry on the next launch. SDK freshness also requires every package-exported output. Explicitjust setupcontinues to force the complete setup workflow.Reviewer-reproducible examples
From a prepared checkout, force the setup path and then exercise the warm development path:
The second command reports:
Changing a workspace manifest, lockfile, SDK schema, generator, configuration, or source invalidates the corresponding output on the next run. A failed dependency install, missing package-exported SDK output, or failed SDK rebuild also leaves that prerequisite stale for automatic repair.