You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will degrade performance by 37.29%
⚠️Different runtime environments detected
Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.
Seeing as this did not actually touch any library code, feels like either we aren't running our benchmarks enough, or we need to run them not in absolute terms but in relative to a control that can account for fluctuations in runtime.
@cowboyd yeah this PR also switched the runners to codspeed-macro which will be consistent—ubuntu-latest varies wildly and was creating a lot of noise. thankfully this should be the last noisy one!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #52. Adds new startup benchmarks in
mode: walltimeto measure the full E2E perf of:createInputbootstrapcreateTerm + createInputbootstrap insidePromise.allrender + scanhitting both modulesalso sets both benchmark jobs to
codspeed-macrorunner to avoid hardware variance, which was causing quite a bit of noise