Skip to content

fix: should complete options after boolean option #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
so1ve wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: should complete options after boolean option #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1bf5470
fix: should complete options after boolean option
so1ve Dec 16, 2025
f4021b0
Create warm-pants-roll.md
so1ve Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/warm-pants-roll.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@bomb.sh/tab": patch
---

fix: should complete options after boolean option
5 changes: 4 additions & 1 deletion src/t.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,10 @@ export class RootCommand extends Command {
const [flag] = toComplete.split('=');
optionName = flag;
} else if (lastPrevArg?.startsWith('-')) {
optionName = lastPrevArg;
const option = this.findOption(command, lastPrevArg);
if (option && !option.isBoolean) {
optionName = lastPrevArg;
}
}

if (optionName) {
Expand Down
7 changes: 7 additions & 0 deletions tests/cli.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,13 @@ describe.each(cliTools)('cli completion tests for %s', (cliTool) => {
// Should complete subcommands that start with 's' even after a boolean option
expect(output).toContain('start');
});

it('should not interfere with option completion after boolean options', async () => {
const command = `${commandPrefix} dev --verbose --h`;
const output = await runCommand(command);
// Should complete subcommands that start with 's' even after a boolean option
expect(output).toContain('--host');
});
});

describe.runIf(!shouldSkipTest)('option API overload tests', () => {
Expand Down