ci: set default Kubernetes version dynamically via Makefile - #115
Open
aswinsreeraj wants to merge 1 commit into
Open
ci: set default Kubernetes version dynamically via Makefile#115aswinsreeraj wants to merge 1 commit into
aswinsreeraj wants to merge 1 commit into
Conversation
Hardcoding the default Kubernetes minor version (1.35) in the integration-tests workflow forces manual search-and-replace updates across multiple files when bumping versions. Add a `print-kube-minor` target to `node-images/fedora/Makefile` to make the Makefile the single source of truth for the default Kubernetes version, and invoke it dynamically in GitHub Actions (`integration-tests.yml`). Closes bootc-dev#87 Signed-off-by: Aswin Sreeraj <aswinsreeraj96@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the default Kubernetes version (
1.35) was hardcoded in.github/workflows/integration-tests.yml. This created duplication withnode-images/fedora/MakefilewhereKUBE_MINOR ?= 1.35is defined.This PR makes
node-images/fedora/Makefilethe single source of truth forKUBE_MINOR:print-kube-minortarget to.PHONYinnode-images/fedora/Makefile.integration-tests.ymlto dynamically queryDEFAULT=$(make -s -C node-images/fedora print-kube-minor).Fixes #87