Add basic infra for gathering logs and hook up to CI#56
Merged
Conversation
On a fresh cluster, deploy-bink was doing a rollout restart immediately after the initial deploy, which is pointless. Make it conditional on the Deployment already existing, so fresh deploys proceed without interruption. (Yeah, probably going to move off of Makefile and to Justfile in a follow-up...) Assisted-by: Pi (Claude Opus 4.6)
deploy-bink was doing two distinct things: 1. make sure a bink cluster is up and running 2. redeploy the bootc-operator controller Let's split out the first part into a separate `start-bink` target. That'll allow us to split the steps more in CI but also is prep for error-handling related stuff.
Add a new `hack/gather-logs.sh` for log gathering from the bink cluster and the controller and a new `gather-bink` Makefile target that calls it. Generally useful but also prep for hooking it up to CI. Assisted-by: Pi (Claude Opus 4.6)
Call hack/gather-logs.sh from cleanup() before deleting pools and removing nodes, so that the cluster state is captured while everything is still alive. The script is called on every test run (pass or fail) to provide a complete record of cluster state. Log gathering is gated on the ARTIFACTS environment variable. When unset (e.g. running go test directly), gathering is silently skipped. Assisted-by: Pi (Claude Opus 4.6)
We need better visibility into failing e2e tests so let's capture logs.
alicefr
approved these changes
Jun 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When tests fail in CI, there is currently very low visibility into what actually went wrong. This patch series should improve the situation.
See individual commits for details.