podstorage: Add early check for missing podman binary - #2386
Open
HarshwardhanPatil07 wants to merge 1 commit into
Open
podstorage: Add early check for missing podman binary#2386HarshwardhanPatil07 wants to merge 1 commit into
HarshwardhanPatil07 wants to merge 1 commit into
Conversation
When podman is not installed, CStorage::create() fails with "No such file or directory (os error 2)" from the underlying Command::new() call, which users misinterpret as a missing file or directory on disk. Add an early have_executable() check that bails with a clear message naming the missing binary, following the same pattern used by ukify.rs. Closes: bootc-dev#2284 Assisted-by: AI Signed-off-by: HarshwardhanPatil07 <harshpat@redhat.com>
Johan-Liebert1
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When podman is not installed, "No such file or directory (os error 2)" is shown, which users misinterpret as a missing file or directory on disk.
Before fix:
error: Upgrading: No such file or directory (os error 2)
After fix:
error: Upgrading: Creating imgstorage: nonexistent_podman executable not found in PATH; it is required for container image storage operations
Steps to reproduce:
Closes: #2284