Improve roundtrip test to go through waffle machinery#11
Merged
cfallin merged 1 commit intobytecodealliance:mainfrom Feb 26, 2026
Merged
Improve roundtrip test to go through waffle machinery#11cfallin merged 1 commit intobytecodealliance:mainfrom
cfallin merged 1 commit intobytecodealliance:mainfrom
Conversation
When creating a `Module` with `from_wasm_bytes` and then outputting again with `to_wasm_bytes` never touches the waffle machinery. That is because `from_wasm_bytes` creates unexpanded `FuncDecl::Lazy` variants and those are outputted as is when calling `to_wasm_bytes`. This change ensures that all function bodies are expanded and gone through the optimization step.
daxhuiberts
force-pushed
the
improve-roundtrip-test
branch
from
dfaf8b5 to
80a25a9
Compare
Member
|
Ah, thank you for catching this! I failed to update the test after implementing lazy function expansion... |
cfallin
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a
Modulewithfrom_wasm_bytesand then outputting again withto_wasm_bytesnever touches the waffle machinery.That is because
from_wasm_bytescreates unexpandedFuncDecl::Lazyvariants and those are outputted as is when callingto_wasm_bytes.This change ensures that all function bodies are expanded and gone through the optimization step.