Define VMContext and VMComponentContext in a macro - #14083
Open
fitzgen wants to merge 1 commit into
Open
Conversation
And automatically generate their offsets, alias region load/store helpers, etc... from the single macro definition. Similar to the existing macro for other `VM*` types, but these definitions are parameterized over a specific Wasm module or component and the entities defined therein.
github-actions
Bot
added
wasmtime:api
Subscribe to Label ActionDetailsThis issue or pull request has been labeled: "wasmtime:api", "winch"Thus the following users have been cc'd because of the following labels:
To subscribe or unsubscribe from this label, edit the |
alexcrichton
approved these changes
Aug 7, 2026
| /// Return a pointer to the collector-specific heap data. | ||
| pub fn gc_heap_data(self: Pin<&mut Self>) -> &mut Option<VmPtr<u8>> { | ||
| let offset = self.offsets().ptr.vmctx_gc_heap_data(); | ||
| let offset = self.offsets().ptr.vmctx().gc_heap_data(); |
Member
There was a problem hiding this comment.
Since accesses like this (throughout the runtime) can be perf-sensitive, have you double-checked that methods are inlined and/or #[inline]'d as needed?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And automatically generate their offsets, alias region load/store helpers, etc... from the single macro definition. Similar to the existing macro for other
VM*types, but these definitions are parameterized over a specific Wasm module or component and the entities defined therein.