feat: demo-trading support added #519
Conversation
php-binance-api.php
Outdated
| $this->useTestnet = (bool)$param[2]; | ||
| break; | ||
| case 4: | ||
| $useDemo = (bool)$param[3]; |
There was a problem hiding this comment.
@yzh-pelle what if the user provides 3 args, (apiKey/secret/demo)?
There was a problem hiding this comment.
right now to enable demo by default we would need to provide also testnet which is a bit weird, maybe we can replace testnet here with demo since testnet is deprecated
There was a problem hiding this comment.
Third arg is for testnet. It is not python, args must be queued. We might add more examples for constructor
There was a problem hiding this comment.
right now to enable demo by default we would need to provide also testnet which is a bit weird, maybe we can replace testnet here with demo since testnet is deprecated
Yeah I was thinking about it. We may leave constructor as is, set default testnet url to demo and add method like useOldUrlForTestnet
2 participants
No description provided.