Fix/multiple fixes#247
Conversation
Ensure that it redirects home if embed mode not set
The .0 is being removed in the dav library.
Filtering now operates on the full resource list before pagination, so page counts and page navigation always reflect the filtered result rather than the raw total. A watcher resets to page 1 whenever any filter changes to prevent landing on an empty page. The "Shared By" filter deduplicates by user id instead of display name, so two accounts with identical display names are no longer merged into one option. When two users share the same display name, the account id is appended in parentheses to distinguish them. SharedWithMeSection accepts optional paginationPages/paginationPage props so the parent can supply the correct filtered page count to the pagination control.
… space checks Updated the DriveRedirect component to utilize the new useSpacesLoading hook, allowing it to show a loading spinner while spaces are being loaded. Additionally, improved the logic to display a "not found" message when no personal space exists for a personal alias. Updated unit tests to reflect these changes and ensure proper functionality.
|
Reviewed PR 247 against cernbox. The filter/pagination ordering, shared-by deduplication by user id, and .0 filename handling look sound. Three regressions should be fixed before merge:
The redirect watchEffect sets showNotFound = true whenever personalSpace is missing. It does not use spacesLoading or spacesInitialized from the spaces store. While spaces are still loading, valid personal aliases (personal, personal/home, empty alias) take the failure path and render NotFoundMessage instead of the loading spinner. Unknown non-personal aliases can also show not-found too early; that should only happen after spaces have finished loading.
The test expects router.replace({ name: 'files-spaces-projects' }) when no personal space exists. With an empty spaces list, personalSpace is undefined and the PR shows not-found instead of redirecting to projects. The test fails against current behavior and does not cover the loading vs not-found transition.
After filter-then-paginate, scrollToResourceFromRoute is called with the current page items only (paginatedFilteredItems). Before pagination was applied at this level, scroll used the full sorted filtered list. Deep links / scrollTo for a share on page 2 or later will not find the resource in the array passed to scroll. |
2 participants
Multiple fixes; the commit messages should be clear what they do. Will update the Jira tickets afterwards.