Widen spacesState mock type to match spaces store#250
Merged
Conversation
The spaces Pinia store exposes spacesInitialized, mountPointsInitialized and spacesLoading, but the shared PiniaMockOptions.spacesState test type only declared spaces and currentSpace. Tests passing the loading flags (e.g. DriveRedirect.spec.ts) were rejected by vue-tsc with TS2353.
diocas
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #247 added loading-state tests to
DriveRedirect.spec.tsthat passspacesInitializedandspacesLoadingthrough the shared Pinia mock helper. However, thePiniaMockOptions.spacesStatetype inpackages/web-test-helpers/src/mocks/pinia.tsonly declaredspacesandcurrentSpace, sovue-tscrejected the extra properties with TS2353, breaking the type-check build after #247 merged.This widens the
spacesStatemock type to match the realspacesPinia store, which exposesspacesInitialized,mountPointsInitialized, andspacesLoadingin addition tospacesandcurrentSpace. At runtime these values were already handled correctly (spread intoinitialState.spaces); only the type definition was out of date.Changes
PiniaMockOptions.spacesStatewith optionalspacesInitialized,mountPointsInitialized, andspacesLoadingfields.Test plan
pnpm exec vitest run packages/web-app-files/tests/unit/views/spaces/DriveRedirect.spec.tspasses (2/2).pnpm check:typesno longer reports the TS2353 error onDriveRedirect.spec.ts/spacesState.