Allow users to configure custom link component#563
Open
virginiacc wants to merge 6 commits intomainfrom
Open
Conversation
|
flacoman91
reviewed
May 4, 2026
| to, | ||
| children, | ||
| ...others | ||
| }: CustomLinkProperties): JSXElement | null => { |
Collaborator
There was a problem hiding this comment.
The null is unnecessary here since the custom type returns that.
Suggested change
| }: CustomLinkProperties): JSXElement | null => { | |
| }: CustomLinkProperties): JSXElement => { |
flacoman91
reviewed
May 4, 2026
| export const useDSRContext = () => use(DSRContext); | ||
|
|
||
| export interface DSRProviderProperties { | ||
| LinkComponent: React.ComponentType<BaseLinkProperties> | null; |
Collaborator
There was a problem hiding this comment.
we should probably remove the null from the public type OR fallback to BaseLink
flacoman91
reviewed
May 4, 2026
flacoman91
reviewed
May 5, 2026
flacoman91
reviewed
May 5, 2026
flacoman91
reviewed
May 5, 2026
flacoman91
reviewed
May 5, 2026
flacoman91
reviewed
May 5, 2026
flacoman91
reviewed
May 5, 2026
| @@ -0,0 +1,31 @@ | |||
| import { createContext, use } from 'react' | |||
Collaborator
There was a problem hiding this comment.
Suggested change
| import { createContext, use } from 'react' | |
| import { ComponentType, createContext, use } from 'react'; | |
flacoman91
reviewed
May 5, 2026
flacoman91
reviewed
May 5, 2026
flacoman91
reviewed
May 5, 2026
| export const useDSRContext = () => use(DSRContext); | ||
|
|
||
| export interface DSRProviderProperties { | ||
| LinkComponent: React.ComponentType<BaseLinkProperties> | null; |
Collaborator
There was a problem hiding this comment.
Suggested change
| LinkComponent: React.ComponentType<BaseLinkProperties> | null; | |
| LinkComponent: ComponentType<BaseLinkProperties> | null; |
Co-authored-by: Richard Dinh <1038306+flacoman91@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability for users to globally configure the DSR to use their router's link component.
Changes
LinkComponentvalue. Defaults to aBaseLinkcomponent that outputs an anchor element.Linkcomponent to output theLinkComponentvalue from the DSR contextBreadcrumbscomponent to useLinkinstead of anchor elementBreaking changes
toprop instead ofhreffor compatibility with external link componentsHow to test this PR
toinstead ofhrefTo do