Add footer variants#564
Open
virginiacc wants to merge 4 commits intomainfrom
Open
Conversation
|
Collaborator
|
I took a close look at the footer component from a visual perspective and I have some very minor feedback. In .o-footer
I am working with Ans to standardize the top and bottom padding on the cf.gov footer side as well. |
natalia-fitzgerald
requested changes
May 7, 2026
Collaborator
There was a problem hiding this comment.
Storybook menu
- For consistency with other components, remove the word "footer" from the variants. And let's add "(cf.gov)" in parenthesis next to "Website" for some added context. We do that for the "Banner (US gov)" component.
- Footers
- Overview
- Website (cf.gov)
- Application
Website footer (cf.gov)
- Instead of the generic content for the website footer, can we add the CFPB content? That way React sites that want to use this footer have it ready to go out of the box.
- Also, some of the social icons are missing. Were these removed from the cf.gov footer code?
Mobile margin adjustments:
- Change margin under "Back to top" button to 45px (currently set to 30px)
- Change margin under social links to 30px (currently 45px)
- Change margin above tagline to 45px (currently set to 30px)
Show only application and cf.gov website variants in stories. Update mobile margins.
Collaborator
|
@virginiacc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a base Footer component with Website and Application variants.
Changes
How to test this PR