Extract fileChanges normalization

[bluwy]

Refactor only. No changesets.

Previously, our APIs wraps other APIs like this:

• commitFilesFromDirectory -> commitFilesFromBuffers -> commitFilesFromBase64
• commitChangesFromRepo -> commitFilesFromBuffers -> commitFilesFromBase64
• commitFilesFromBuffers -> commitFilesFromBase64
• commitFilesFromBase64

What they have all in common is commitFilesFromBase64. They really only are commitFilesFromBase64 + syntactic sugar to compute the fileChanges differently. So my idea is that commitFilesFromBase64 should be the only function tested e2e/integration, how fileChanges are computed can be entirely tested as unit tests.

So in this PR, I refactored the APIs to like this:

• commitFilesFromDirectory -> commitFilesFromBase64 + normalizeFileChanges
• commitChangesFromRepo -> commitFilesFromBase64 + getFileChanges
• commitFilesFromBuffers -> commitFilesFromBase64 + normalizeFileChanges
• commitFilesFromBase64

Now, we're able to test each file changes themselves as unit test. The integration tests will later need to be refactored to test with commitFilesFromBase64 only and then it should be much simpler to run.

[socket-security]

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	fs-fixture@​2.14.0

View full report