Support branch and tag format for commitChangesFromRepo base#111
Open
bluwy wants to merge 1 commit into
Open
Conversation
bluwy
commented
Jun 18, 2026
Comment on lines
-19
to
-21
| // For explicit commit bases we don't resolve the base oid from a ref, | ||
| // but the shared metadata query still expects a valid qualified ref name. | ||
| return "HEAD"; |
Member
Author
There was a problem hiding this comment.
This part is refactored away as we can avoid accessing info.baseRef in this state.
If base: { commit: "123" } is passed, info.baseRef would be null as it doesn't support direct SHAs. This is fine because we're not going to access it anyways in
const baseSha = "commit" in base ? base.commit : getBaseRefSha(info.baseRef);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So it's the same API as
commitFilesFromBase64. No reason to not support either as long as the branch and tag is locally available for diffing.I also did some small refactor in
core.tsto renameoidtoshaas discussed before.