Skip to content

Release 8.8.0 - #696

Merged
rodrigojara-cko merged 1 commit into
masterfrom
release/8.8.0
Oct 22, 2026
Merged

rodrigojara-cko merged 1 commit into
masterfrom
release/8.8.0

Conversation

@rodrigojara-cko

Copy link
Copy Markdown
Contributor
  • Payments: add fallback_source to the payment request, an alternative card source attempted when the primary source fails. RequestCardSource gains allowUpdate.
  • Issuing: card control responses deserialize mid_limit controls and expose is_editable. VelocityLimit gains the response-only amountRemaining.
  • Payment setups: Pay by Bank is sent under the paybybank key; the previous key was ignored by the API. Adds the Pay by Bank risk object.
  • Payment setups: card data is sent under card.details and card.token. Add schemes and preferred_scheme to card, Apple Pay and Google Pay (Google Pay accepts visa and mastercard), company_name to the account holder, settings capture and excluded_payment_methods, payment_methods auto_confirm, metadata on the request and responses, and the read-only instrument type and Klarna iban.
  • Payment setups: order sub-merchants send number_of_sales.

Breaking changes required by the API:

  • Payment setups: the Apple Pay and Google Pay token is now a WalletToken object (id, expires_on) instead of a String.
  • Payment setups: the flat Card accessors (number, last4, bin, scheme, expiry month and year, name, cvv, stored, expiresOn, allowUpdate), the wallet expiresOn accessors and OrderSubMerchant numberOfTrades are removed. Use card.details, token.expiresOn and numberOfSales. The API never read the old shape, so those values were being dropped.

Deprecated:

  • PaymentMethodStatus PENDING and AVAILABLE, which are not part of the API enum.

- Payments: add fallback_source to the payment request, an alternative card source attempted when the primary source fails. RequestCardSource gains allowUpdate.
- Issuing: card control responses deserialize mid_limit controls and expose is_editable. VelocityLimit gains the response-only amountRemaining.
- Payment setups: Pay by Bank is sent under the paybybank key; the previous key was ignored by the API. Adds the Pay by Bank risk object.
- Payment setups: card data is sent under card.details and card.token. Add schemes and preferred_scheme to card, Apple Pay and Google Pay (Google Pay accepts visa and mastercard), company_name to the account holder, settings capture and excluded_payment_methods, payment_methods auto_confirm, metadata on the request and responses, and the read-only instrument type and Klarna iban.
- Payment setups: order sub-merchants send number_of_sales.

Breaking changes required by the API:
- Payment setups: the Apple Pay and Google Pay token is now a WalletToken object (id, expires_on) instead of a String.
- Payment setups: the flat Card accessors (number, last4, bin, scheme, expiry month and year, name, cvv, stored, expiresOn, allowUpdate), the wallet expiresOn accessors and OrderSubMerchant numberOfTrades are removed. Use card.details, token.expiresOn and numberOfSales. The API never read the old shape, so those values were being dropped.

Deprecated:
- PaymentMethodStatus PENDING and AVAILABLE, which are not part of the API enum.
@agent-wall-e

agent-wall-e Bot commented Oct 22, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 22, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Oct 22, 2026

Copy link
Copy Markdown

🔵 Advisory review: Sound, but needs your judgement

This PR needs a human approval. The code itself reads as correct; whether it should land depends on context I don't have.

The diff provided shows only a version bump from 8.7.0 to 8.8.0 in gradle.properties, but the PR description claims extensive breaking changes, new fields, renamed keys, and deprecated enum values. A human reviewer must verify that all the described changes are actually present in the full changeset and that the version bump is appropriate.

For you to decide

  • The diff is partial — only gradle.properties is shown, so none of the claimed functional changes (fallback_source, paybybank key fix, card.details/card.token, WalletToken breaking change, amountRemaining, etc.) can be verified against the code.
  • The PR description claims breaking changes (WalletToken replacing String, removed flat Card accessors, removed numberOfTrades) which would normally warrant a major semver bump, but a minor bump (8.7.0 → 8.8.0) is used — a human should confirm this aligns with the project's versioning policy.
  • The paybybank key fix is described as a bug fix (previous key was ignored by the API), meaning existing callers silently had their Pay by Bank data dropped; the human reviewer should confirm this regression is being corrected and assess downstream impact.
  • The deprecation of PaymentMethodStatus PENDING and AVAILABLE should be verified to ensure deprecated annotations or warnings are present in the actual source, not just mentioned in the PR description.

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@sonarqubecloud

Copy link
Copy Markdown

@rodrigojara-cko
rodrigojara-cko requested a review from a team October 22, 2026 11:27
@rodrigojara-cko rodrigojara-cko changed the title Release 8.8.0 - Payment setup alignment Release 8.8.0 Oct 22, 2026
@rodrigojara-cko
rodrigojara-cko merged commit 488ce57 into master Oct 22, 2026
6 checks passed
@rodrigojara-cko
rodrigojara-cko deleted the release/8.8.0 branch October 22, 2026 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants