docs(payments): document ProcessingData response fields on GET /payments/{id} - #447
Open
armando-rodriguez-cko wants to merge 1 commit into
Open
docs(payments): document ProcessingData response fields on GET /payments/{id}#447armando-rodriguez-cko wants to merge 1 commit into
armando-rodriguez-cko wants to merge 1 commit into
Conversation
…nts/{id}
Adds scheme, partner_fraud_status and partner_merchant_advice_code to the
pass-through response notes, mirroring the swagger ProcessingData schema.
The SDK returns the raw JSON, so JSDoc is the discoverability surface.
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 1 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The diff is purely a JSDoc comment addition with zero runtime changes, satisfying all conditions for a documentation-only logical extension of existing code.
wall-e 2026.06.19-02 · policy 376219bc71e6…
|
david-ruiz-cko
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
Documents the response-only
processingfieldsscheme,partner_fraud_statusandpartner_merchant_advice_codeonPayments.get, aligning the Node SDK with the swaggerProcessingDataschema (INT-1668).The Node SDK returns the raw API JSON (
Promise<Object>) and does not model response payloads, so the JSDoc pass-through block is the discoverability surface for response fields. This follows the pattern already used onPayments.request.Changes
src/api/payments/payments.js— added aprocessingpass-through block to thePayments.getJSDoc listingscheme,partner_fraud_status,partner_merchant_advice_code, plus the previously undocumentedscheme_transaction_link_id,failure_code,partner_code,partner_response_codeandfallback_source_usedAPI Reference
GET /payments/{id}—PaymentDetails.processing(ProcessingDataschema)Breaking changes
None. Documentation only, no runtime change.
README
No impact. The README does not document individual response fields.