Skip to content

docs(payments): document ProcessingData response fields on GET /payments/{id} - #447

Open
armando-rodriguez-cko wants to merge 1 commit into
masterfrom
feat/INT-1668-processing-data-response-fields
Open

docs(payments): document ProcessingData response fields on GET /payments/{id}#447
armando-rodriguez-cko wants to merge 1 commit into
masterfrom
feat/INT-1668-processing-data-response-fields

Conversation

@armando-rodriguez-cko

Copy link
Copy Markdown
Contributor

Summary

Documents the response-only processing fields scheme, partner_fraud_status and partner_merchant_advice_code on Payments.get, aligning the Node SDK with the swagger ProcessingData schema (INT-1668).

The Node SDK returns the raw API JSON (Promise<Object>) and does not model response payloads, so the JSDoc pass-through block is the discoverability surface for response fields. This follows the pattern already used on Payments.request.

Changes

  • src/api/payments/payments.js — added a processing pass-through block to the Payments.get JSDoc listing scheme, partner_fraud_status, partner_merchant_advice_code, plus the previously undocumented scheme_transaction_link_id, failure_code, partner_code, partner_response_code and fallback_source_used

API Reference

  • GET /payments/{id}PaymentDetails.processing (ProcessingData schema)

Breaking changes

None. Documentation only, no runtime change.

README

No impact. The README does not document individual response fields.

…nts/{id}

Adds scheme, partner_fraud_status and partner_merchant_advice_code to the
pass-through response notes, mirroring the swagger ProcessingData schema.
The SDK returns the raw JSON, so JSDoc is the discoverability surface.
@agent-wall-e

agent-wall-e Bot commented Aug 6, 2026

Copy link
Copy Markdown

🟢 Risk Classification: LOW

Approval route: AI Auto-Approval
Rollback controls: Automated Instant Rollback + feature flags

Classification reasons

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The diff is purely a JSDoc comment addition with zero runtime changes, satisfying all conditions for a documentation-only logical extension of existing code.

Operational gates

  • ✅ jira_ticket (INT-1668)
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Aug 6, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.
2.2.6_logical_extensionThe diff is purely a JSDoc comment addition with zero runtime changes, satisfying all conditions for a documentation-only logical extension of existing code. classifying §2.2.6 Sonnet 4.6 evaluator promoted minor → low: the change reuses existing code paths and does not cross a trust boundary.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e agent-wall-e Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approved — this PR meets all Low-risk criteria.

All checks passed, no unresolved comments, and the change classification is:

  • no_low_class_matched
  • prod_source_modified
  • 2.2.6_logical_extension:The diff is purely a JSDoc comment addition with zero runtime changes, satisfying all conditions for a documentation-only logical extension of existing code.

wall-e 2026.06.19-02 · policy 376219bc71e6…

@sonarqubecloud

sonarqubecloud Bot commented Aug 6, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants