Issue #5770: method wrapper for the log(line, column,..) DetailNode#19123
Open
DakshRJain737 wants to merge 1 commit intocheckstyle:masterfrom
Open
Issue #5770: method wrapper for the log(line, column,..) DetailNode#19123DakshRJain737 wants to merge 1 commit intocheckstyle:masterfrom
DakshRJain737 wants to merge 1 commit intocheckstyle:masterfrom
Conversation
Contributor
Author
|
reopen after other PR merge |
Contributor
Author
|
Any update?? |
DakshRJain737
force-pushed
the
abstractJavadocCheck-switch-logging-DetailNode
branch
from
2904ac9 to
63afcf2
Compare
DakshRJain737
force-pushed
the
abstractJavadocCheck-switch-logging-DetailNode
branch
from
63afcf2 to
1520288
Compare
romani
reviewed
Apr 19, 2026
Member
romani
left a comment
romani
left a comment
There was a problem hiding this comment.
Did you migrate all Check that does logging line and col ?
You upgraded only 3 , we have a bit more Checks, but they might be logging by line number only.
Contributor
Author
|
I think i covered at all places.
Yes there are many checks that logs by line number only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #5770
Added a wrapper method log(DetailNode node, String key, Object... args) for log(int line, int column, ..).