some fixes.. context, custom titles,..#4
Open
jdlx wants to merge 17 commits intochrisboulton:masterfrom
jdlx:master
Open
some fixes.. context, custom titles,..#4jdlx wants to merge 17 commits intochrisboulton:masterfrom jdlx:master
jdlx wants to merge 17 commits intochrisboulton:masterfrom
jdlx:master
Conversation
… render name instead of class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dear chris,
i finally jumped.. on using GIT ;-) so here are my changes. Besides the custom titles change, and that one typo, i found the bug with the non working context option.. well at least it works for me now. The catch was getGroupedOpcodes() being called without the context option passed in Diff.php..
However: getGroupedOpcodes() is also being called in Array.php, Context.php and Unified.php.. again without the option beiing passed, and at this point i'm not sure whether that matters in some place or not..
well, goog enough for now.. ;)
cheers,
Jan