-
Notifications
You must be signed in to change notification settings - Fork 2
Add UnityHub CLI args to Open command #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add UnityHub CLI args to Open command #34
Conversation
chrisyarbrough
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, works like a charm!
I have projects with this setup, for example:
-logFile SomeCustom/Path/Editor.log -cacheServerEnableDownload false -cacheServerEnableUpload false
Please fix the minor formatting issues. Maybe it works to apply the suggestions from the GitHub UI, if not, please fix locally. Thank you! (Or I will when merging, but I thought it makes sense to pass on the feedback.)
|
|
||
| ProjectInfo project = Project.Parse(searchPath); | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extraneous tabs.
| [Description("Open only the code editor without launching Unity")] | ||
| public bool OnlyCodeEditor { get; init; } | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra line.
| { | ||
| return string.Empty; | ||
| } | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove extra line.
| AnsiConsole.MarkupLine($"[cyan]{message}...[/]"); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove newline at end of file. I wish I could just add this as a suggestion, but I guess removal of newline doesn't work.
| // If you remove args from project in Unity Hub, this field still will exist but now with empty value, | ||
| // so we can't guarantee that it has value and we need to check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // If you remove args from project in Unity Hub, this field still will exist but now with empty value, | |
| // so we can't guarantee that it has value and we need to check | |
| // The cliArgs field persists even when arguments are removed from a project in Unity Hub, | |
| // but will contain an empty value. Validation is required before use. |
Implementation of #15