Fix #32 cant open project on windows #36
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug arose due to the confusion:
Unity.app(the bundle), but we need to append the sub-path to the binaryUnity.app/Contents/MacOS/Unity)Unity.exe, which can be executed directly.UnityHub.GetEditorPathwas usingplatformSupport.RelativeEditorPathToExecutableto append to the path on mac correctly, but incorrectly on Windows, butPlatformSupport.FindInstallationRootwas using the relative path correctly to convert from Unity.exe to the root.To clear up the confusion, I introduced
FindInstallationRootas a platform-specific method and also introducedGetUnityExecutablePathto append the mac-part only on mac.The goal is to keep assumptions about each platform within each respective Windows/MacSupport class.