Skip to content

Transport data refresh (walker split 1/4) - #1839

Open
infuse21 wants to merge 1 commit into
chsami:developmentfrom
infuse21:pr1-transport-data
Open

Transport data refresh (walker split 1/4)#1839
infuse21 wants to merge 1 commit into
chsami:developmentfrom
infuse21:pr1-transport-data

Conversation

@infuse21

Copy link
Copy Markdown
Contributor

What

Part 1 of 4 splitting #1838 into reviewable PRs, per review feedback there. This part is the transport data refresh only — 15 files, zero code.

  • Coverage and coordinate corrections found by live walks: agility_shortcuts, canoes, minecarts, quetzals, ships, transports, teleportation_items/spells/minigames.
  • Duration corrections: spirit tree rows had a blank Duration column, and non-teleport transports get no minimum — so every spirit tree edge cost the planner exactly zero, and it picked them even when a short walk was faster (user-reported). Spirit trees blank→10, gnome gliders 8→12, magic mushtrees blank→6, proportionate to the existing convention (fairy ring 5, quetzal 6, charter 6, boats 9, ships 10).
  • blocked_edges/restrictions: doors that never open and edges the live game refuses.
  • collision-map.zip regenerated for newer map areas.

Review notes

  • Every file parses with the loader already on development — unknown header columns are ignored by the parser, so no code rides along.
  • Full unit suite (:client:runUnitTests) green on this branch.
  • The remaining parts: (2) pinned upstream-planner source set + gradle wiring, (3) shortestpath engine, (4) walker executor — opening sequentially as agreed.

🤖 Generated with Claude Code

Refreshed transport data from several weeks of live walking, delivered
as data only — every file parses with the loader already on
development (unknown header columns are ignored; no code changes).

- agility_shortcuts, canoes, minecarts, quetzals, ships, transports,
  teleportation_items/spells/minigames: coverage and coordinate
  corrections found by live walks.
- DURATION CORRECTIONS: spirit tree rows had a blank Duration column
  and non-teleport transports get no minimum, so every spirit tree
  edge cost the planner exactly ZERO — it picked them even when a
  short walk was faster. Spirit trees blank -> 10, gnome gliders
  8 -> 12, magic mushtrees blank -> 6, proportionate to the existing
  convention (fairy ring 5, quetzal 6, charter 6, boats 9, ships 10).
- blocked_edges/restrictions: entries for doors that never open and
  edges the live game refuses.
- collision-map.zip regenerated (newer map areas).

Part 1 of splitting chsami#1838 into reviewable PRs. Full suite
(:client:runUnitTests) green on this branch.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (15)
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/agility_shortcuts.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/blocked_edges.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/canoes.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/collision-map.zip is excluded by !**/*.zip
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/gnome_gliders.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/magic_mushtrees.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/minecarts.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/quetzals.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/restrictions.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/ships.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/spirit_trees.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_items.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_minigames.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/teleportation_spells.tsv is excluded by !**/*.tsv
  • runelite-client/src/main/resources/net/runelite/client/plugins/microbot/shortestpath/transports.tsv is excluded by !**/*.tsv

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 68107d9b-2376-405b-9e7d-5f4de31c34a6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@infuse21

Copy link
Copy Markdown
Contributor Author

Note on the CodeRabbit skip above: it's the repo's own path filters (!**/*.tsv, !**/*.zip) — data files are excluded from automated review by configuration, so this PR will never receive a CodeRabbit pass regardless of size. The review surface here is the 15-file data diff itself plus the green unit suite, which exercises the loader over every changed file. The code-bearing parts of the split (2–4) are within CodeRabbit's scope.

🤖 Generated with Claude Code

@infuse21
infuse21 marked this pull request as draft August 15, 2026 13:16
@infuse21

Copy link
Copy Markdown
Contributor Author

i have found some issues that need to be addressed before the pr happens . i have set to draft for now.

@infuse21
infuse21 marked this pull request as ready for review August 15, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant