fix(shortestpath): refresh transport data and reopen Al Kharid Palace - #1842
Open
infuse21 wants to merge 2 commits into
Open
fix(shortestpath): refresh transport data and reopen Al Kharid Palace#1842infuse21 wants to merge 2 commits into
infuse21 wants to merge 2 commits into
Conversation
Refreshed transport data from several weeks of live walking, delivered as data only — every file parses with the loader already on development (unknown header columns are ignored; no code changes). - agility_shortcuts, canoes, minecarts, quetzals, ships, transports, teleportation_items/spells/minigames: coverage and coordinate corrections found by live walks. - DURATION CORRECTIONS: spirit tree rows had a blank Duration column and non-teleport transports get no minimum, so every spirit tree edge cost the planner exactly ZERO — it picked them even when a short walk was faster. Spirit trees blank -> 10, gnome gliders 8 -> 12, magic mushtrees blank -> 6, proportionate to the existing convention (fairy ring 5, quetzal 6, charter 6, boats 9, ships 10). - blocked_edges/restrictions: entries for doors that never open and edges the live game refuses. - collision-map.zip regenerated (newer map areas). Part 1 of splitting chsami#1838 into reviewable PRs. Full suite (:client:runUnitTests) green on this branch. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (15)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. WalkthroughThe test suite removes Al Kharid mine perimeter and rerouting coverage. It adds palace entrance and destination coordinates. A parameterized test verifies that the pathfinder enters Al Kharid Palace from the north, produces a non-empty path, completes successfully, and reaches each expected destination. Obsolete mine-specific assertion helpers and containment helpers are removed. Merge Risk: ⚪ Minimal · up to This PR refreshes shortest-path data, reopens Al Kharid Palace routes, and adds regression coverage; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is PR 1 of 6. Each PR is kept below 100 changed files for CodeRabbit. The remaining slices will be rebased and opened sequentially after their predecessor merges so earlier files are not counted again.
Validation
:client:runUnitTests --tests net.runelite.client.plugins.microbot.shortestpath.ShortestPathCoreTestScope
16 changed files relative to
development.