🍕 Collect destructured process.env vars in Vite env collector#245
Merged
Conversation
The env collector only matched `process.env.FOO` and missed
`const { FOO } = process.env` in universal services imported into
browser bundles. Missing keys then dropped out of client-env.json,
showing up as undefined/null in client runtime.
Add destructuring support (including aliases/defaults) and tests.
Made-with: Cursor
|
coverage: 64.247% (+0.2%) from 64.054% — jordan/fix-vite-env-collector-destructure into master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib/cmd/vite/plugins/client-env.jsto collect env vars from destructuring assignments onprocess.env.process.env.FOO) as before.client-env.test.js.Why
Some universal services use:
The previous collector regex only matched
process.env.FOO, so destructured keys were omitted fromclient-env.jsonand appeared undefined/null in browser runtime.Test plan
npm run lintnpx jest lib/cmd/vite/plugins/client-env.test.jsMade with Cursor