feat(clerk-js,shared): Add parsing for SBB fields#7785
feat(clerk-js,shared): Add parsing for SBB fields#7785dstaley wants to merge 1 commit intofeat/seat-based-billingfrom
Conversation
dstaley
requested review from
l-armstrong,
mauricioabreu,
mzhong9723 and
paddycarver
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 09a0fda The changes in this PR will be included in the next version bump. This PR includes changesets to release 20 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| /** | ||
| * The unique identifier of the unit price tier. | ||
| */ | ||
| id: string; |
There was a problem hiding this comment.
I don't remember, were we exposing this?
| * Represents a single pricing tier for a unit type on a plan. | ||
| */ | ||
| export interface BillingPlanUnitPriceTierJSON { | ||
| id: string; |
There was a problem hiding this comment.
I forget if we were exposing this or not.
There was a problem hiding this comment.
nikosdouvlis
left a comment
nikosdouvlis
left a comment
There was a problem hiding this comment.
Looks good to me, left a minor comment
| * | ||
| * Represents a single pricing tier for a unit type on a plan. | ||
| */ | ||
| export interface BillingPlanUnitPriceTierJSON { |
There was a problem hiding this comment.
BillingPlanUnitPriceTierJSON defines id and object inline rather than extending ClerkResourceJSON like other JSON types that have both fields (e.g. FeatureJSON). Any reason to keep it standalone, or should it extend ClerkResourceJSON for consistency?
4 participants
Description
This PR adds parsing support for the new seat-based billing fields from FAPI.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change