Skip to content

fix(clerk-js): Remove beforeunload event listener from SafeLock#7817

Closed
wobsoriano wants to merge 3 commits intorelease/core-2from
rob/pr-7775-core-2
Closed

fix(clerk-js): Remove beforeunload event listener from SafeLock#7817
wobsoriano wants to merge 3 commits intorelease/core-2from
rob/pr-7775-core-2

Conversation

@wobsoriano
Copy link
Member

@wobsoriano wobsoriano commented Feb 10, 2026

Description

Core 2 version of #7775

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

wobsoriano and others added 2 commits February 10, 2026 13:39
@wobsoriano
fix(repo): Handle framework query param in Next.js keyless test
d3a0de6 
Update the Next.js keyless integration test to verify that claim URLs
include the framework=nextjs query parameter.

This aligns with backend changes that add framework query params to
claim URLs for dashboard analytics and proper routing.

Changes:
- Check for 'framework=nextjs' in sign_in_force_redirect_url
- Check for 'framework=nextjs' in sign_up_force_redirect_url (both regular and prepare-account cases)
- Use .includes() instead of .startsWith() for more flexible URL validation
- Properly handle URL-encoded framework parameter in prepare-account flow

Test coverage:
✅ Sign-in redirect URL contains framework=nextjs
✅ Sign-up redirect URL contains framework=nextjs (regular case)
✅ Sign-up redirect URL contains framework=nextjs (prepare-account case)
✅ All other claim URL parameters (token, dashboard URL) still validated
@bsingerftm @claude
@nikosdouvlis @coderabbitai @wobsoriano
fix(clerk-js): Remove beforeunload event listener from SafeLock (#7775)
194d93f 
Co-authored-by: Claude <noreply@anthropic.com>
Co-authored-by: Nikos Douvlis <nikosdouvlis@gmail.com>
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 49ecb19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/clerk-js Patch
@clerk/chrome-extension Patch
@clerk/clerk-expo Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Feb 10, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
clerk-js-sandbox Ready Ready Preview, Comment Feb 10, 2026 11:36pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 10, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch rob/pr-7775-core-2

Comment @coderabbitai help to get the list of available commands and usage tips.

@wobsoriano wobsoriano closed this Feb 10, 2026
@wobsoriano wobsoriano deleted the rob/pr-7775-core-2 branch February 10, 2026 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

clerk-js core-2 integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@wobsoriano @bsingerftm