fix(clerk-js): Fix broken transitive state for org switch and sign out

.changeset/olive-oranges-march.md

@@ -0,0 +1,6 @@
+---
+'@clerk/clerk-js': patch
+'@clerk/testing': patch
+---
+
+Fix `toBeSignedOut` test-helper so it only resolves when `user === null`. It previously resolved for any falsy value, which could give false positives when Clerk had not loaded yet, or during auth-state changes.

integration/templates/next-app-router/src/app/transitive-state/organization-switcher/[orgId]/page.tsx

@@ -0,0 +1,9 @@
+export default async function Page({ params }: { params: Promise<{ orgId: string }> }) {
+  const { orgId } = await params;
+
+  return (
+    <div>
+      <p data-testid='current-org-id'>{orgId}</p>
+    </div>
+  );
+}

integration/templates/next-app-router/src/app/transitive-state/organization-switcher/layout.tsx

@@ -0,0 +1,47 @@
+'use client';
+
+import { OrganizationSwitcher, useAuth } from '@clerk/nextjs';
+import { useState } from 'react';
+import { usePathname } from 'next/navigation';
+
+function EmissionLog() {
+  const { orgId } = useAuth();
+  const pathname = usePathname();
+  const [log, setLog] = useState<string[]>([]);
+
+  const entry = `${pathname} - ${orgId}`;
+  if (entry !== log[log.length - 1]) {
+    setLog(prev => [...prev, entry]);
+  }
+
+  return (
+    <ul data-testid='emission-log'>
+      {log.map((entry, i) => (
+        <li
+          key={i}
+          data-testid={`emission-${i}`}
+        >
+          {entry}
+        </li>
+      ))}
+    </ul>
+  );
+}
+
+export default function Layout({ children }: { children: React.ReactNode }) {
+  return (
+    <div style={{ margin: '40px' }}>
+      <div style={{ marginBottom: '20px' }}>
+        <OrganizationSwitcher
+          fallback={<div>Loading organization switcher</div>}
+          afterSelectOrganizationUrl='/transitive-state/organization-switcher/:id'
+        />
+      </div>
+      <div style={{ marginBottom: '20px' }}>
+        <h2>Emission log</h2>
+        <EmissionLog />
+      </div>
+      {children}
+    </div>
+  );
+}

integration/templates/next-app-router/src/app/transitive-state/sign-out/layout.tsx

@@ -0,0 +1,41 @@
+'use client';
+
+import { useAuth } from '@clerk/nextjs';
+import { useState } from 'react';
+import { usePathname } from 'next/navigation';
+
+function EmissionLog() {
+  const { userId } = useAuth();
+  const pathname = usePathname();
+  const [log, setLog] = useState<string[]>([]);
+
+  const entry = `${pathname} - ${String(userId)}`;
+  if (entry !== log[log.length - 1]) {
+    setLog(prev => [...prev, entry]);
+  }
+
+  return (
+    <ul data-testid='emission-log'>
+      {log.map((entry, i) => (
+        <li
+          key={i}
+          data-testid={`emission-${i}`}
+        >
+          {entry}
+        </li>
+      ))}
+    </ul>
+  );
+}
+
+export default function Layout({ children }: { children: React.ReactNode }) {
+  return (
+    <div style={{ margin: '40px' }}>
+      <div style={{ marginBottom: '20px' }}>
+        <h2>Emission log</h2>
+        <EmissionLog />
+      </div>
+      {children}
+    </div>
+  );
+}

integration/templates/next-app-router/src/app/transitive-state/sign-out/page.tsx

@@ -0,0 +1,10 @@
+import { SignOutButton } from '@clerk/nextjs';
+
+export default function Page() {
+  return (
+    <div>
+      <p data-testid='page-name'>sign-out</p>
+      <SignOutButton redirectUrl='/transitive-state/sign-out/sign-in' />
+    </div>
+  );
+}

integration/templates/next-app-router/src/app/transitive-state/sign-out/sign-in/page.tsx

@@ -0,0 +1,3 @@
+export default function Page() {
+  return <p data-testid='page-name'>sign-in</p>;
+}

integration/templates/next-app-router/src/app/transitive-state/user-button/layout.tsx

@@ -0,0 +1,47 @@
+'use client';
+
+import { UserButton, useAuth } from '@clerk/nextjs';
+import { useState } from 'react';
+import { usePathname } from 'next/navigation';
+
+function EmissionLog() {
+  const { userId } = useAuth();
+  const pathname = usePathname();
+  const [log, setLog] = useState<string[]>([]);
+
+  const entry = `${pathname} - ${userId}`;
+  if (entry !== log[log.length - 1]) {
+    setLog(prev => [...prev, entry]);
+  }
+
+  return (
+    <ul data-testid='emission-log'>
+      {log.map((entry, i) => (
+        <li
+          key={i}
+          data-testid={`emission-${i}`}
+        >
+          {entry}
+        </li>
+      ))}
+    </ul>
+  );
+}
+
+export default function Layout({ children }: { children: React.ReactNode }) {
+  return (
+    <div style={{ margin: '40px' }}>
+      <div style={{ marginBottom: '20px' }}>
+        <UserButton
+          fallback={<div>Loading user button</div>}
+          afterSwitchSessionUrl='/transitive-state/user-button/switched'
+        />
+      </div>
+      <div style={{ marginBottom: '20px' }}>
+        <h2>Emission log</h2>
+        <EmissionLog />
+      </div>
+      {children}
+    </div>
+  );
+}

integration/templates/next-app-router/src/app/transitive-state/user-button/page.tsx

@@ -0,0 +1,3 @@
+export default function Page() {
+  return <p data-testid='page-name'>initial</p>;
+}

integration/templates/next-app-router/src/app/transitive-state/user-button/switched/page.tsx

@@ -0,0 +1,3 @@
+export default function Page() {
+  return <p data-testid='page-name'>switched</p>;
+}

integration/tests/impersonation-flow.test.ts

@@ -58,7 +58,9 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('Impersona
     // Pass through the ticket flow
     const searchParams = new URLSearchParams();
     searchParams.set('__clerk_ticket', actorTokenResponse.token);
-    await u.po.signIn.goTo({ searchParams });
+    // We don't use u.signIn.goTo here since the navigation can happen so quickly
+    // that Playwright can miss catching the sign in component having been mounted
+    await u.page.goToRelative('/sign-in', { searchParams });
 
     // Ensure that the impersonation flow is successful
     await u.po.expect.toBeSignedInAsActor();

integration/tests/localhost/localhost-different-port-different-instance.test.ts

@@ -61,8 +61,8 @@ test.describe('multiple apps running on localhost using different Clerk instance
     expect(tab0Cookies.filter(c => c.name.startsWith('__clerk_db_jwt'))).toHaveLength(2);
     expect(tab0Cookies.filter(c => c.name.startsWith('__client_uat'))).toHaveLength(2);
 
-    await u[1].po.expect.toBeSignedOut();
     await u[1].po.signIn.goTo();
+    await u[1].po.expect.toBeSignedOut();
     await u[1].po.signIn.signInWithEmailAndInstantPassword(fakeUsers[1]);
     await u[1].po.expect.toBeSignedIn();
 

integration/tests/localhost/localhost-different-port-same-instance.test.ts

@@ -93,6 +93,8 @@ test.describe('multiple apps running on localhost using same Clerk instance @loc
 
     // sign out from tab1
     await u[1].page.goToAppHome();
+    // This also ensures Clerk has loaded before evaluating the signOut
+    await u[1].po.expect.toBeSignedIn();
     await u[1].page.evaluate(() => window.Clerk.signOut());
     await u[1].po.expect.toBeSignedOut();
 

integration/tests/sign-out-smoke.test.ts

@@ -87,6 +87,7 @@ testAgainstRunningApps({ withEnv: [appConfigs.envs.withEmailCodes] })('sign out
     await u.page.getByRole('button', { name: 'Open user menu' }).click();
 
     await u.page.getByRole('menuitem', { name: 'Sign out' }).click();
+    await u.po.expect.toBeSignedOut();
     await u.page.getByRole('link', { name: 'Protected', exact: true }).click();
     await u.page.waitForURL(url => url.href.includes('/sign-in?redirect_url'));
   });