Skip to content

feat: update pgwire to 0.37#3910

Open
sunng87 wants to merge 6 commits intoclockworklabs:masterfrom
sunng87:feature/pgwire-037
Open

feat: update pgwire to 0.37#3910
sunng87 wants to merge 6 commits intoclockworklabs:masterfrom
sunng87:feature/pgwire-037

Conversation

@sunng87
Copy link
Contributor

@sunng87 sunng87 commented Dec 19, 2025

Description of Changes

Update pgwire to 0.37

Make DataRowEncoder reusable as enabled in this release, make introduce 3x performance on encoding.

API and ABI breaking changes

N/A

Expected complexity level and risk

N/A

Testing

@bfops
Copy link
Collaborator

bfops commented Dec 19, 2025

Thank you for opening this! We'll work on getting it reviewed.

@joshua-spacetime joshua-spacetime self-requested a review February 26, 2026 20:49
Signed-off-by: joshua-spacetime <josh@clockworklabs.io>
@bfops
Copy link
Collaborator

bfops commented Feb 27, 2026

I think this is failing tests due to some changes in serialization, which would be a breaking change for us.

@sunng87
Copy link
Contributor Author

sunng87 commented Feb 28, 2026

@bfops Yes, let me look into the error when I get time.

auto-merge was automatically disabled March 13, 2026 06:30

Head branch was pushed to by a user without write access

@sunng87
Copy link
Contributor Author

sunng87 commented Mar 13, 2026

@bfops this change is related to a correction of how we encode bytea_array in pgwire. The are additional bytes required for bytea_array than bytea. However, when I check the usage of bytea_array in spacetimedb, I think we should correct to bytea because bytea is already byte array, while bytea_array is array of byte arrays. Changing the data type will fix the encoding issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants