Skip to content

Fix spacetime logout failing when offline #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bfops merged 1 commit into from
Feb 23, 2026
Merged

Fix spacetime logout failing when offline #4361

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions crates/cli/src/subcommands/logout.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
use std::time::Duration;

use crate::Config;
use clap::{Arg, ArgMatches, Command};
use reqwest::Url;
Expand All @@ -16,12 +18,19 @@ pub async fn exec(mut config: Config, args: &ArgMatches) -> Result<(), anyhow::E
let host = Url::parse(host)?;

if let Some(web_session_token) = config.web_session_token() {
let client = reqwest::Client::new();
client
let client = reqwest::Client::builder().timeout(Duration::from_secs(5)).build()?;
let result = client
.post(host.join("auth/cli/logout")?)
.header("Authorization", format!("Bearer {web_session_token}"))
.send()
.await?;
.await;

if let Err(e) = result {
eprintln!(
"Warning: Could not reach auth server to invalidate session: {e}\n\
Local credentials have been cleared."
);
}
}

config.clear_login_tokens();
Expand Down
Loading