Merged
Conversation
bfops
commented
Mar 6, 2026
jdetter
approved these changes
Mar 6, 2026
bfops
commented
Mar 6, 2026
Collaborator
Author
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
submitting a review to bump the check
bfops
commented
Mar 6, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
The previous version ended up incurring two different entries on the PR (one for the
pull_requestevent and one for thepull_request_reviewevent). Both versions were marked "required", so PRs could end up in an unmergeable state if one check had succeeded but the other had failed (e.g. if you submitted a PR approval, the previouspull_requestversion of the check would still be failed since it didn't refresh).See the entries at top and bottom here:
This PR fixes it by only allowing the
pull_request_reviewevents. I think this covers all the cases, but I'm not sure.API and ABI breaking changes
None.
Expected complexity level and risk
1
Testing
I don't know how to test it really 🤷