[C#] Primary keys for query builder views#4626
Merged
joshua-spacetime merged 8 commits intomasterfrom Mar 13, 2026
Merged
Conversation
joshua-spacetime
force-pushed
the
joshua/cs/transfer-pk-to-view-v2
branch
from
a33d86d to
48c4ee6
Compare
rekhoff
approved these changes
Mar 12, 2026
Contributor
rekhoff
left a comment
rekhoff
left a comment
There was a problem hiding this comment.
These are the same changes as #4614 , just targeting master, so my approval in #4614 carries over to this one. The only difference is the removal of a separate view-pk-client regression test, which has now been folded into the existing client regression test. This change has also been reviewed and looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Same change set as #4614, just targeting master.
The return type of a query builder view is now a special SATS product type
{ __query__: T }. A view with this return type now has a primary key ifThas a primary key. This means that client codegen will generate anOnUpdatecallback for such views. It will also generate query builder index bindings for the primary key column.API and ABI breaking changes
None. Old modules with query builder views still work, they just don't have primary keys.
Expected complexity level and risk
2
Testing
Added equivalent tests to the ones that were added in #4573 and #4572.