Open
Conversation
aaa038c to
ead8bf1
Compare
ead8bf1 to
6bf9438
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This patch removes the dead legacy SQL query engine and the remaining code that only existed to support it.
Removed:
spacetimedb-vmcrateSmall pieces still used by the current engine were moved to their proper homes instead of keeping the
vmcrate around. In particular, theRelValuewas moved tospacetimedb-execution.The
sqltestcrate was also updated to use the current engine. Notably though these tests are not run in CI, however I've kept them around as they may be beneficial as we look to expand our SQL support in the future.API and ABI breaking changes
None
Expected complexity level and risk
1
Testing
None