Skip to content

Remove legacy SQL code#4628

Open
joshua-spacetime wants to merge 2 commits intomasterfrom
joshua/remove-old-query-code
Open

Remove legacy SQL code#4628
joshua-spacetime wants to merge 2 commits intomasterfrom
joshua/remove-old-query-code

Conversation

@joshua-spacetime
Copy link
Collaborator

Description of Changes

This patch removes the dead legacy SQL query engine and the remaining code that only existed to support it.

Removed:

  • Old SQL compiler/type-checker and VM-based execution path in spacetimedb-core
  • spacetimedb-vm crate
  • Dead vm specific error variants and compatibility code
  • Obsolete tests, benchmarks, and config paths that still referenced the legacy engine

Small pieces still used by the current engine were moved to their proper homes instead of keeping the vm crate around. In particular, the RelValue was moved to spacetimedb-execution.

The sqltest crate was also updated to use the current engine. Notably though these tests are not run in CI, however I've kept them around as they may be beneficial as we look to expand our SQL support in the future.

API and ABI breaking changes

None

Expected complexity level and risk

1

Testing

None

@joshua-spacetime joshua-spacetime changed the title Joshua/remove old query code Remove legacy SQL code Mar 12, 2026
@joshua-spacetime joshua-spacetime force-pushed the joshua/remove-old-query-code branch 2 times, most recently from aaa038c to ead8bf1 Compare March 12, 2026 22:34
@joshua-spacetime joshua-spacetime force-pushed the joshua/remove-old-query-code branch from ead8bf1 to 6bf9438 Compare March 12, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant