Skip to content

Bump HTTP procedure timeouts: 500ms/10s → 30s/180s #4632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
clockwork-labs-bot wants to merge 1 commit into from
Closed

Bump HTTP procedure timeouts: 500ms/10s → 30s/180s #4632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions crates/core/src/host/instance_env.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -970,12 +970,16 @@ impl InstanceEnv {

/// Default timeout for HTTP requests performed by [`InstanceEnv::http_request`].
///
/// Value chosen arbitrarily by pgoldman 2025-11-18, based on little more than a vague guess.
const HTTP_DEFAULT_TIMEOUT: Duration = Duration::from_millis(500);
/// Applied when the module does not specify a timeout.
/// 30 seconds is generous enough for most external API calls (including LLM APIs)
/// without silently hanging forever on a broken endpoint.
const HTTP_DEFAULT_TIMEOUT: Duration = Duration::from_secs(30);
/// Maximum timeout for HTTP requests performed by [`InstanceEnv::http_request`].
///
/// If the user requests a timeout longer than this, we will clamp to this value.
const HTTP_MAX_TIMEOUT: Duration = Duration::from_secs(10);
/// 180 seconds accommodates long-running LLM and AI API calls,
/// which routinely take 30-120 seconds for complex requests.
const HTTP_MAX_TIMEOUT: Duration = Duration::from_secs(180);
const BLOCKED_HTTP_ADDRESS_ERROR: &str = "refusing to connect to private or special-purpose addresses";

struct FilteredDnsResolver;
Expand Down
Loading