Support Option values in index filters#4949
Open
Mr-Dust0 wants to merge 3 commits into
Open
Conversation
Contributor
|
Hi @Mr-Dust0 , please see the docs here about why this is more work than it may first appear: https://github.com/clockworklabs/SpacetimeDB/pull/4024/changes#diff-3ce7e5c02154d19ebe0624a457ea8b0c30a6b1658a24856ed1ea2ec3ee28916a. |
04b404e to
9d7547d
Compare
9d7547d to
b789158
Compare
Contributor
Author
|
Hi @bfops, I’ve updated the PR to cover the additional work you shared in the docs. The changes I've made add TypeScript module-side support for indexed/unique optional columns, keep non-filterable option types rejected at compile time, and normalize null/undefined option-none comparisons in the TypeScript table cache. I also kept the Rust and C# coverage in place. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4824.
Test Plan