Skip to content

Allow monomorphization for reducers and more #5610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
lisandroct wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Allow monomorphization for reducers and more #5610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c72d4a4
Bring #2151 to post .NET 10
lisandroct Jul 9, 2026
d6c0f77
Add static generic caches for reducers and more
lisandroct Jul 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
344 changes: 294 additions & 50 deletions crates/bindings-csharp/Codegen.Tests/fixtures/diag/snapshots/Module#FFI.verified.cs
View file
Open in desktop

Large diffs are not rendered by default.

141 changes: 97 additions & 44 deletions crates/bindings-csharp/Codegen.Tests/fixtures/explicitnames/snapshots/Module#FFI.verified.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,7 +511,7 @@ public sealed partial class LocalReadOnly

static class ModuleRegistration
{
class DemoReducer : SpacetimeDB.Internal.IReducer
sealed class DemoReducer : SpacetimeDB.Internal.IReducer
{
private static readonly SpacetimeDB.BSATN.I32 valueRW = new();

Expand All @@ -534,7 +534,7 @@ public void Invoke(BinaryReader reader, SpacetimeDB.Internal.IReducerContext ctx
}
}

class DemoProcedure : SpacetimeDB.Internal.IProcedure
sealed class DemoProcedure : SpacetimeDB.Internal.IProcedure
{
public SpacetimeDB.Internal.RawProcedureDefV10 MakeProcedureDef(
SpacetimeDB.BSATN.ITypeRegistrar registrar
Expand Down Expand Up @@ -646,18 +646,34 @@ public static SpacetimeDB.Internal.Errno __call_reducer__(
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink error
) =>
SpacetimeDB.Internal.Module.__call_reducer__(
id,
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp,
args,
error
);
id switch
{
0
=> SpacetimeDB.Internal.Module.__call_reducer__<DemoReducer>(
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp,
args,
error
),
_
=> SpacetimeDB.Internal.Module.__call_reducer__(
id,
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp,
args,
error
)
};

[UnmanagedCallersOnly(EntryPoint = "__call_procedure__")]
public static SpacetimeDB.Internal.Errno __call_procedure__(
Expand All @@ -672,18 +688,34 @@ public static SpacetimeDB.Internal.Errno __call_procedure__(
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink result_sink
) =>
SpacetimeDB.Internal.Module.__call_procedure__(
id,
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp,
args,
result_sink
);
id switch
{
0
=> SpacetimeDB.Internal.Module.__call_procedure__<DemoProcedure>(
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp,
args,
result_sink
),
_
=> SpacetimeDB.Internal.Module.__call_procedure__(
id,
sender_0,
sender_1,
sender_2,
sender_3,
conn_id_0,
conn_id_1,
timestamp,
args,
result_sink
)
};

[UnmanagedCallersOnly(EntryPoint = "__call_http_handler__")]
public static SpacetimeDB.Internal.Errno __call_http_handler__(
Expand All @@ -694,14 +726,18 @@ public static SpacetimeDB.Internal.Errno __call_http_handler__(
SpacetimeDB.Internal.BytesSink response_sink,
SpacetimeDB.Internal.BytesSink response_body_sink
) =>
SpacetimeDB.Internal.Module.__call_http_handler__(
id,
timestamp,
request,
request_body,
response_sink,
response_body_sink
);
id switch
{
_
=> SpacetimeDB.Internal.Module.__call_http_handler__(
id,
timestamp,
request,
request_body,
response_sink,
response_body_sink
)
};

[UnmanagedCallersOnly(EntryPoint = "__call_view__")]
public static SpacetimeDB.Internal.Errno __call_view__(
Expand All @@ -713,22 +749,39 @@ public static SpacetimeDB.Internal.Errno __call_view__(
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink sink
) =>
SpacetimeDB.Internal.Module.__call_view__(
id,
sender_0,
sender_1,
sender_2,
sender_3,
args,
sink
);
id switch
{
0
=> SpacetimeDB.Internal.Module.__call_view__<demo_viewViewDispatcher>(
sender_0,
sender_1,
sender_2,
sender_3,
args,
sink
),
_
=> SpacetimeDB.Internal.Module.__call_view__(
id,
sender_0,
sender_1,
sender_2,
sender_3,
args,
sink
)
};

[UnmanagedCallersOnly(EntryPoint = "__call_view_anon__")]
public static SpacetimeDB.Internal.Errno __call_view_anon__(
uint id,
SpacetimeDB.Internal.BytesSource args,
SpacetimeDB.Internal.BytesSink sink
) => SpacetimeDB.Internal.Module.__call_view_anon__(id, args, sink);
) =>
id switch
{
_ => SpacetimeDB.Internal.Module.__call_view_anon__(id, args, sink)
};
#endif
}

Expand Down
Loading
Loading