Middleware and metric to track per-database HTTP response egress - #5611
Open
gefjon wants to merge 2 commits into
Open
Middleware and metric to track per-database HTTP response egress#5611gefjon wants to merge 2 commits into
gefjon wants to merge 2 commits into
Conversation
This commit adds a new Prometheus metric, `spacetime_http_response_size_bytes_total`, which tracks bytes sent as responses to HTTP requests related to the database. This includes the `sql` and `call` routes, guest-defined HTTP handlers, logs, plus some misc. management routes. Notably, the `subscribe` route, which initiates a long-lived WebSocket connection, is not counted by the new metric, as we already track its egress separately. The new metric is tracked by an Axum middleware.
gefjon
added
the
release-any
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
This commit adds a new Prometheus metric,
spacetime_http_response_size_bytes_total, which tracks bytes sent as responses to HTTP requests related to the database. This includes thesqlandcallroutes, guest-defined HTTP handlers, logs, plus some misc. management routes. Notably, thesubscriberoute, which initiates a long-lived WebSocket connection, is not counted by the new metric, as we already track its egress separately.The new metric is tracked by an Axum middleware.
API and ABI breaking changes
N/a
Expected complexity level and risk
1 or 2? I don't have a huge amount of confidence any time I touch our Axum stuff, but this is just metrics, and (at least currently) not billed metrics.
Testing