Update release-npm workflow for dryruns - #5634
Closed
rekhoff wants to merge 2 commits into
Closed
Conversation
Collaborator
|
I didn't realize you had already started a PR for this. Closing in favor of the merged #5636 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the npm dry-run failures observed in recent release-dry-run CI runs, where
pnpm publish --dry-runcontacts the npm registry and errors out for already-published versions likespacetimedb@2.7.1.Description of Changes
Updates
tools/release/src/targets/npm.rsso that in dry-run mode the npm release target:pnpm run prepublishOnlyto execute the build/test/size checkspnpm packto create the tarball locallyThe live
pnpm publish --no-git-checkspath is unchanged. This also makes the log and error messages accurate for whichever mode is running.API and ABI breaking changes
No changes.
Expected complexity level and risk
Low. Only the dry-run branch of
tools/release/src/targets/npm.rsis changed. The live npm publish path still runspnpm publish.Testing
cargo clippy -p spacetimedb-releasepasses.cargo-release release npm v2.7.1 --dry-runor therelease-dry-runworkflow on a branch.