Repository navigation
Conversation
|
The project owner and the administrators shared the same OIDC group
(/{slug}/console/admin), making ownership indistinguishable from admin in
every SSO-group-mapped service. A new system role Propriétaire seeds
/{slug}/console/owner: the Keycloak reconciler adds the implicit owner
there instead of the admin group, and ownership transfers grant it so the
previous owner keeps access under their own group. Project-tier admin
group defaults in sonarqube, gitlab, nexus, registry and vault now include
the owner group, keeping the owner's access level while separating the
groups. ArgoCD is left out: its suffix lands as a single string in Helm
values consumed by the external chart, which cannot take a list.
Refs #2853
Co-authored-by: Automata <automata@shikanime.studio>
Signed-off-by: William Phetsinorath <william.phetsinorath-open@interieur.gouv.fr>
Change-Id: I07c2163bfe1a89837085d42ba7a211c56a6a6964
shikanime
force-pushed
the
feat/owner-oidc-group
branch
from
October 15, 2026 13:39
d5be01c to
845c61b
Compare
| import { PrismaService } from '../infrastructure/database/prisma.service' | ||
| import { StartActiveSpan } from '../infrastructure/telemetry/telemetry.decorator' | ||
| import { isAdminRole } from '../keycloak/keycloak.utils' | ||
| import { isOwnerRole } from '../keycloak/keycloak.utils' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

0 New Issues
0 Fixed Issues
0 Accepted Issues
Pourquoi
Le propriétaire d'un projet et ses administrateurs partagent le même groupe OIDC (
/{slug}/console/admin) : l'appartenance est indiscernable côté Keycloak et dans tous les services mappés sur les groupes SSO. La séparation propriétaire/admin exige un groupe dédié/{slug}/console/owner, créé et peuplé comme les autres groupes de rôles.Empilée sur #2854 (le transfert accorde le rôle ; ce PR rend ce rôle distinct d'Administrateur).
Quoi
MANAGE,oidcGroup /{slug}/console/owner) : seedé à la création du projet, backfillé par migration idempotente sur les projets existants (les positions existantes décalent d'un cran)isOwnerRoledans keycloak.utils ; la réconciliation Keycloak ajoute le propriétaire implicite au groupe owner au lieu du groupe adminRéférences
20260908155700_add_security_role