Make purge-build-queue-by-name.groovy more flexible#162
Open
cbdchang wants to merge 1 commit intocloudbees:masterfrom
Open
Make purge-build-queue-by-name.groovy more flexible#162cbdchang wants to merge 1 commit intocloudbees:masterfrom
cbdchang wants to merge 1 commit intocloudbees:masterfrom
Conversation
duemir
requested changes
Mar 15, 2021
Member
duemir
left a comment
duemir
left a comment
There was a problem hiding this comment.
Let us polish it a bit. I suggested some changes. WDYT?
| //Purge build queue by name | ||
|
|
||
| // find tasks by name which contains string pattern REPLACEME | ||
| import hudson.model.* |
Member
There was a problem hiding this comment.
Suggested change
| import hudson.model.* |
This one is implicit so no need to explicitly import. Also Jenkins class is in the jenkins.model package, not in hudson.model so pointless anyway.
| q.items.findAll { it.task.name.contains('REPLACEME') }.each { println it.task.name } | ||
|
|
||
| // purge | ||
| import hudson.model.* |
Member
There was a problem hiding this comment.
Suggested change
| import hudson.model.* |
as above
| import hudson.model.* | ||
| def q = Jenkins.instance.queue | ||
| q.items.findAll { it.task.name.startsWith('REPLACEME') }.each { q.cancel(it.task) } | ||
| q.items.findAll { it.task.name.contains('REPLACEME') }.each { println it.task.name } |
Member
There was a problem hiding this comment.
Suggested change
| q.items.findAll { it.task.name.contains('REPLACEME') }.each { println it.task.name } | |
| Queue.getInstance().items.findAll { it.task.name.contains('REPLACEME') }.each { println it.task.name } |
Since this does not have to reuse the q to cancel task, it can be reduced to one line.
|
|
||
| // find tasks by name which contains string pattern REPLACEME | ||
| import hudson.model.* | ||
| def q = Jenkins.instance.queue |
Member
There was a problem hiding this comment.
Suggested change
| def q = Jenkins.instance.queue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed startsWith to contains. Added a sample query first.