Repository navigation
fix(http): reject invalid UTF-8 in encoded attributes - #310
Open
zhanghao0806 wants to merge 1 commit into
Open
zhanghao0806 wants to merge 1 commit into
zhanghao0806 wants to merge 1 commit into
Conversation
Signed-off-by: zhanghao <112082360+zhanghao0806@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Decode percent-encoded HTTP CloudEvents attributes with strict UTF-8 validation.
unquote()previously substituted replacement characters for malformed byte sequences, silently changing attribute values. The HTTP binding requires those sequences to be rejected.Fixes #307. Specification: https://github.com/cloudevents/spec/blob/v1.0.2/cloudevents/bindings/http-protocol-binding.md#3132-http-header-values
Validation
from_binaryandfrom_http.pytest -q: 887 passed, 18 xfailed.git diff --check: passed.+.The sender's encoding policy is unchanged. Prepared with AI assistance; commits are signed off.