[NOT-FOR-REVIEW] Add @all-autogates test variant to wd_test #5768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danlapid
changed the title
danlapid
force-pushed
the
dlapid/all-compat-flags-variant
branch
8 times, most recently
from
c9f1897 to
46c88b4
Compare
Add a --compat-date CLI flag to `workerd test` that overrides the compatibility date for all workers. When this flag is used, workers must NOT specify compatibilityDate in the config - this allows the test harness to control the compat date externally. The wd_test macro now generates three variants: - name@ (default): oldest compat date (2000-01-01) - name@all-compat-flags: newest compat date (2999-12-31) - name@all-autogates: all autogates + oldest compat date Tests can selectively disable variants using generate_default_variant, generate_all_compat_flags_variant, and generate_all_autogates_variant flags. Also adds test cases to verify the compat-flag variants work correctly by checking Cloudflare.compatibilityFlags.formdata_parser_supports_files is enabled/disabled based on the compat date.
First we bulk remove compat date from all tests. Then we add enable-flags to make the default variant pass. Then we add disable-flags to make the all-compat-flags variant pass. A few important points about this commit: 1. Python tests don't run all-compat-flags and all-autogates variants. I made them all pass under those variants and then disabled the variants. The impact on CI times is just way too high to justify the value sadly. We need to find a way to improve python test CI times and then reenable them.
danlapid
force-pushed
the
dlapid/all-compat-flags-variant
branch
from
46c88b4 to
83a682e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.