Skip to content

health-check-type is ignored from manifest.yml when pushing application #108

Open
Open
health-check-type is ignored from manifest.yml when pushing application#108

Description

@ivankoster
ivankoster
opened on Nov 12, 2020

When using the pushoperation health-check-type and related fields are ignored from a manifest file.
This is caused by the v2 api of cf using the same field names, but the dashes are converted to underscores.

The fields with dashes are dropped in _generate_application_update_request in apps.py because AppManager.APPLICATION_FIELDS does not contain them, but the underscored versions.

Activity

  1. antechrestos commented on Dec 12, 2020

    @antechrestos
    antechrestos
    on Dec 12, 2020
    Member

    @ivankoster Hi. I am not sure I understand very well. You mean that

    • manifest could contain health-check-type or health-check-http-endpoint
    • if provided, set application attribute to health_check_type and or health-check-http-endpoint

    Is that so? Would you like provide a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions