refactor: define agent config in code - #458
Conversation
|
Warning Review limit reached
Next review available in: 50 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (28)
WalkthroughThe integration package now exports 🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@integration/test_environment.go`:
- Around line 695-712: Add focused tests for
TestEnvironment.CreateAgentConfigFile that verify the generated
agent-config.json contents, including preservation of an explicit
Platform.Linux.ServiceManager and fallback to t.serviceManager when it is empty.
Cover successful remote installation and assert the helper returns no error,
using the existing integration-test setup and command/file helpers.
- Around line 708-712: Update the configuration replacement flow around
CopyFileToPath to remove the preceding sudo rm command, preserving the existing
/var/vcap/bosh/agent.json until the staged copy succeeds and is moved into
place.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 38241090-06ce-4f6b-83e5-97f4e6f9008b
📒 Files selected for processing (28)
integration/agent_config.gointegration/apply_test.gointegration/assets/file-settings-agent-no-default-tmp-dir-systemd.jsonintegration/assets/file-settings-agent-no-default-tmp-dir.jsonintegration/assets/file-settings-agent-root-partition-systemd.jsonintegration/assets/file-settings-agent-root-partition.jsonintegration/assets/file-settings-agent-systemd.jsonintegration/assets/file-settings-agent.jsonintegration/bundle_logs_test.gointegration/compile_package_test.gointegration/delete_arp_entries_test.gointegration/ephemeral_disk_test.gointegration/fetch_logs_test.gointegration/fetch_logs_with_signed_url_test.gointegration/file_settings_test.gointegration/instance_info_test.gointegration/integration_suite_test.gointegration/nats_firewall_test.gointegration/prepare_test.gointegration/raw_ephemeral_disk_test.gointegration/remove_file_test.gointegration/run_script_test.gointegration/sync_dns_test.gointegration/system_mounts_test.gointegration/test_environment.gointegration/update_settings_test.gointegration/user_permissions_test.gointegration/v1_apply_test.go
💤 Files with no reviewable changes (6)
- integration/assets/file-settings-agent-no-default-tmp-dir-systemd.json
- integration/assets/file-settings-agent-no-default-tmp-dir.json
- integration/assets/file-settings-agent-root-partition-systemd.json
- integration/assets/file-settings-agent-root-partition.json
- integration/assets/file-settings-agent-systemd.json
- integration/assets/file-settings-agent.json
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Inbox
to Waiting for Changes | Open for Contribution
in Foundational Infrastructure Working Group
|
probably should rebase this on top of #457 |
after adding copies of the agent config that used systemd, it seemed execessive to have 6 json config files used by tests instead, we can just define a default config in code, let the test harnesss determine if sysetmd is being used, and edit the agent config as needed per test ai-assisted=yes [TNZ-106038] Refactor bosh-agent CI pipeline to run integration tests on all supported stemcell lines (Jammy, Noble, Resolute)
4066cdc to
fcbb856
Compare
github-project-automation
Bot
moved this from Waiting for Changes | Open for Contribution
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
|
closing because we are folding this change into #457 |
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
1 participant
What is this change about?
after adding copies of the agent config that used systemd, it seemed execessive to have 6 json config files used by tests
instead, we can just define a default config in code, let the test harnesss determine if sysetmd is being used, and edit the agent config as needed per test
ai-assisted=yes
Please provide contextual information.
[TNZ-106038] Refactor bosh-agent CI pipeline to run integration tests on all supported stemcell lines (Jammy, Noble, Resolute)
What tests have you run against this PR?
TODO
How should this change be described in bosh-agent release notes?
N/A
Does this PR introduce a breaking change?
No
Tag your pair, your PM, and/or team!
@mkocher
AI Review Feedback
All AI review comments (CodeRabbit, and Copilot when assigned) must be resolved before human reviewers will look at the PR. For each comment, either: